Hi,

After this change, exceptions handled by discard_on seem to get notified. Is that intentional? I'd expect discarded exceptions not to be reported.

After this change, exceptions handled by discard_on seem to get notified. Is that intentional? I'd expect discarded exceptions not to be reported.

Yes, this is expected as there isn't an API to detect if an error would be discarded. An error being discarded also doesn't necessarily mean it's unimportant to know about, since errors that would make a job impossible to finish will often end up being discarded to prevent retries that will never succeed

If you have errors that you don't want to end up in Bugsnag, you can use the discard_classes option to discard an error by name. If the logic needs to be more complicated then you can use an on error callback instead. For example, to ignore a specific combination of error and job:

Bugsnag.configure do |config|
  config.add_on_error(proc do |report|
    next if report.exceptions.empty?
    next if report.meta_data[:active_job].nil?

    error_class = report.exceptions.first[:errorClass]
    job_name = report.meta_data[:active_job][:job_name]

    if error_class == 'ClassToIgnore' && job_name == 'JobToIgnore'
      false # ignore the report
    end
  end)
end